Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add appless pre-PAT onboarding container #3629

Open
wants to merge 4 commits into
base: cy/non_pat_appless
Choose a base branch
from

Conversation

calvin-codecov
Copy link
Contributor

@calvin-codecov calvin-codecov commented Jan 3, 2025

Description

Closes codecov/engineering-team#2735

Code Example

Notable Changes

Screenshots

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-staging
Copy link

codecov-staging bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 6 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ts/Header/components/UserDropdown/UserDropdown.tsx 50.00% 5 Missing ⚠️
...rc/pages/OwnerPage/OnboardingOrg/OnboardingOrg.tsx 90.90% 1 Missing ⚠️
@@                  Coverage Diff                   @@
##           cy/non_pat_appless    #3629      +/-   ##
======================================================
- Coverage               98.98%   98.94%   -0.05%     
======================================================
  Files                     810      814       +4     
  Lines                   14551    14611      +60     
  Branches                 4136     4166      +30     
======================================================
+ Hits                    14404    14457      +53     
- Misses                    140      147       +7     
  Partials                    7        7              
Files with missing lines Coverage Δ
src/App.tsx 100.00% <ø> (ø)
...rc/pages/DefaultOrgSelector/DefaultOrgSelector.jsx 100.00% <100.00%> (ø)
src/pages/DefaultOrgSelector/constants.ts 100.00% <100.00%> (ø)
...rBanners/GithubConfigBanner/GithubConfigBanner.jsx 100.00% <ø> (ø)
...s/OwnerPage/OnboardingContainerContext/context.tsx 100.00% <100.00%> (ø)
src/pages/OwnerPage/OnboardingOrg/constants.ts 100.00% <100.00%> (ø)
src/pages/OwnerPage/OwnerPage.jsx 100.00% <100.00%> (ø)
src/shared/AppInstallModal/AppInstallModal.tsx 100.00% <100.00%> (ø)
src/shared/ListRepo/ListRepo.jsx 100.00% <100.00%> (ø)
...rc/pages/OwnerPage/OnboardingOrg/OnboardingOrg.tsx 90.90% <90.90%> (ø)
... and 1 more

... and 18 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 98.32% <50.00%> (-1.40%) ⬇️
Pages 98.71% <96.96%> (-0.01%) ⬇️
Services 99.33% <ø> (-0.04%) ⬇️
Shared 99.38% <100.00%> (+<0.01%) ⬆️
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56cde4f...08f6fb6. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 89.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 98.94%. Comparing base (56cde4f) to head (4bac342).
Report is 6 commits behind head on cy/non_pat_appless.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ts/Header/components/UserDropdown/UserDropdown.tsx 50.00% 5 Missing ⚠️
...rc/pages/OwnerPage/OnboardingOrg/OnboardingOrg.tsx 90.90% 1 Missing ⚠️
@@                  Coverage Diff                   @@
##           cy/non_pat_appless    #3629      +/-   ##
======================================================
- Coverage               98.98%   98.94%   -0.05%     
======================================================
  Files                     810      814       +4     
  Lines                   14551    14612      +61     
  Branches                 4136     4166      +30     
======================================================
+ Hits                    14404    14458      +54     
- Misses                    140      147       +7     
  Partials                    7        7              
Files with missing lines Coverage Δ
src/App.tsx 100.00% <ø> (ø)
...rc/pages/DefaultOrgSelector/DefaultOrgSelector.jsx 100.00% <100.00%> (ø)
src/pages/DefaultOrgSelector/constants.ts 100.00% <100.00%> (ø)
...rBanners/GithubConfigBanner/GithubConfigBanner.jsx 100.00% <ø> (ø)
...s/OwnerPage/OnboardingContainerContext/context.tsx 100.00% <100.00%> (ø)
src/pages/OwnerPage/OnboardingOrg/constants.ts 100.00% <100.00%> (ø)
src/pages/OwnerPage/OwnerPage.jsx 100.00% <100.00%> (ø)
src/services/navigation/useLocationParams.ts 100.00% <100.00%> (ø)
src/shared/AppInstallModal/AppInstallModal.tsx 100.00% <100.00%> (ø)
src/shared/ListRepo/ListRepo.jsx 100.00% <100.00%> (ø)
... and 2 more

... and 18 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 98.32% <50.00%> (-1.40%) ⬇️
Pages 98.71% <96.96%> (-0.01%) ⬇️
Services 99.33% <100.00%> (-0.04%) ⬇️
Shared 99.38% <100.00%> (+<0.01%) ⬆️
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56cde4f...4bac342. Read the comment docs.

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 6 lines in your changes missing coverage. Please review.

Project coverage is 98.94%. Comparing base (56cde4f) to head (08f6fb6).
Report is 6 commits behind head on cy/non_pat_appless.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ts/Header/components/UserDropdown/UserDropdown.tsx 50.00% 5 Missing ⚠️
...rc/pages/OwnerPage/OnboardingOrg/OnboardingOrg.tsx 90.90% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##           cy/non_pat_appless    #3629      +/-   ##
======================================================
- Coverage               98.98%   98.94%   -0.05%     
======================================================
  Files                     810      814       +4     
  Lines                   14551    14611      +60     
  Branches                 4143     4159      +16     
======================================================
+ Hits                    14404    14457      +53     
- Misses                    140      147       +7     
  Partials                    7        7              
Files with missing lines Coverage Δ
src/App.tsx 100.00% <ø> (ø)
...rc/pages/DefaultOrgSelector/DefaultOrgSelector.jsx 100.00% <100.00%> (ø)
src/pages/DefaultOrgSelector/constants.ts 100.00% <100.00%> (ø)
...rBanners/GithubConfigBanner/GithubConfigBanner.jsx 100.00% <ø> (ø)
...s/OwnerPage/OnboardingContainerContext/context.tsx 100.00% <100.00%> (ø)
src/pages/OwnerPage/OnboardingOrg/constants.ts 100.00% <100.00%> (ø)
src/pages/OwnerPage/OwnerPage.jsx 100.00% <100.00%> (ø)
src/shared/AppInstallModal/AppInstallModal.tsx 100.00% <100.00%> (ø)
src/shared/ListRepo/ListRepo.jsx 100.00% <100.00%> (ø)
...rc/pages/OwnerPage/OnboardingOrg/OnboardingOrg.tsx 90.90% <90.90%> (ø)
... and 1 more

... and 18 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 98.32% <50.00%> (-1.40%) ⬇️
Pages 98.71% <96.96%> (-0.01%) ⬇️
Services 99.33% <ø> (-0.04%) ⬇️
Shared 99.38% <100.00%> (+<0.01%) ⬆️
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56cde4f...08f6fb6. Read the comment docs.

Copy link

codecov-public-qa bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 6 lines in your changes missing coverage. Please review.

Project coverage is 98.94%. Comparing base (56cde4f) to head (08f6fb6).
Report is 6 commits behind head on cy/non_pat_appless.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ts/Header/components/UserDropdown/UserDropdown.tsx 50.00% 5 Missing ⚠️
...rc/pages/OwnerPage/OnboardingOrg/OnboardingOrg.tsx 90.90% 1 Missing ⚠️
@@                  Coverage Diff                   @@
##           cy/non_pat_appless    #3629      +/-   ##
======================================================
- Coverage               98.98%   98.94%   -0.05%     
======================================================
  Files                     810      814       +4     
  Lines                   14551    14611      +60     
  Branches                 4136     4166      +30     
======================================================
+ Hits                    14404    14457      +53     
- Misses                    140      147       +7     
  Partials                    7        7              
Files with missing lines Coverage Δ
src/App.tsx 100.00% <ø> (ø)
...rc/pages/DefaultOrgSelector/DefaultOrgSelector.jsx 100.00% <100.00%> (ø)
src/pages/DefaultOrgSelector/constants.ts 100.00% <100.00%> (ø)
...rBanners/GithubConfigBanner/GithubConfigBanner.jsx 100.00% <ø> (ø)
...s/OwnerPage/OnboardingContainerContext/context.tsx 100.00% <100.00%> (ø)
src/pages/OwnerPage/OnboardingOrg/constants.ts 100.00% <100.00%> (ø)
src/pages/OwnerPage/OwnerPage.jsx 100.00% <100.00%> (ø)
src/shared/AppInstallModal/AppInstallModal.tsx 100.00% <100.00%> (ø)
src/shared/ListRepo/ListRepo.jsx 100.00% <100.00%> (ø)
...rc/pages/OwnerPage/OnboardingOrg/OnboardingOrg.tsx 90.90% <90.90%> (ø)
... and 1 more

... and 18 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 98.32% <50.00%> (-1.40%) ⬇️
Pages 98.71% <96.96%> (-0.01%) ⬇️
Services 99.33% <ø> (-0.04%) ⬇️
Shared 99.38% <100.00%> (+<0.01%) ⬆️
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56cde4f...08f6fb6. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Jan 8, 2025

Bundle Report

Changes will increase total bundle size by 139.2kB (0.77%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm 6.13MB 69.83kB (1.15%) ⬆️
gazebo-staging-system 6.07MB 69.38kB (1.16%) ⬆️

Copy link

codecov bot commented Jan 8, 2025

Bundle Report

Changes will increase total bundle size by 139.2kB (0.77%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.07MB 69.38kB (1.16%) ⬆️
gazebo-production-system-esm 6.13MB 69.83kB (1.15%) ⬆️

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
08f6fb6 Wed, 08 Jan 2025 00:56:43 GMT Cloud Enterprise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants